Source file Translation_unit.ml
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
(** Translation units *)
module Location = Migrate_ast.Location
open Parse_with_comments
exception
Internal_error of
[ `Cannot_parse of exn
| `Ast_changed
| `Comment of Cmt.error
| `Warning50 of Location.t * Warnings.t ]
list
* (string * Sexp.t) list
let internal_error msg kvs = raise (Internal_error (msg, kvs))
let chop_any_extension s =
match Filename.chop_extension s with
| r -> r
| exception Invalid_argument _ -> s
let exe = chop_any_extension (Filename.basename Stdlib.Sys.argv.(0))
module Error = struct
type t =
| Invalid_source of {exn: exn; input_name: string}
| Unstable of
{iteration: int; prev: string; next: string; input_name: string}
| Ocamlformat_bug of {exn: exn; input_name: string}
| User_error of string
let user_error x = User_error x
let equal : t -> t -> bool = Poly.equal
let print_diff input_name ~prev ~next =
let ext = Filename.extension input_name in
let input_name =
Filename.chop_extension (Filename.basename input_name)
in
let p = Filename.temp_file input_name (Printf.sprintf ".prev%s" ext) in
let n = Filename.temp_file input_name (Printf.sprintf ".next%s" ext) in
Out_channel.write_all p ~data:prev ;
Out_channel.write_all n ~data:next ;
ignore
(Stdlib.Sys.command
(Printf.sprintf "git diff --no-index -u %S %S | sed '1,4d' 1>&2" p n) ) ;
Stdlib.Sys.remove p ;
Stdlib.Sys.remove n
let print_internal_error ~debug ~quiet fmt e =
let s =
match e with
| `Cannot_parse (Parse_with_comments.Warning50 _) ->
"generating invalid comment attachment"
| `Cannot_parse _ -> "generating invalid ocaml syntax"
| `Ast_changed -> "ast changed"
| `Comment _ -> "comment changed"
| `Warning50 _ -> "misplaced documentation comment"
in
Format.fprintf fmt " BUG: %s.\n%!" s ;
match e with
| `Comment x when not quiet -> Cmt.pp_error fmt x
| `Cannot_parse ((Syntaxerr.Error _ | Lexer.Error _) as exn) ->
if debug then Location.report_exception fmt exn
| `Cannot_parse (Parse_with_comments.Warning50 _) ->
()
| `Cannot_parse exn ->
if debug then Format.fprintf fmt "%s" (Stdlib.Printexc.to_string exn)
| `Warning50 (l, w) -> if debug then Warning.print_warning l w
| _ -> ()
let print ?(debug = false) ?(quiet = false) fmt = function
| Invalid_source _ when quiet -> ()
| Invalid_source {exn; input_name} -> (
let reason =
match exn with
| Syntaxerr.Error _ | Lexer.Error _ -> " (syntax error)"
| Warning50 _ -> " (misplaced documentation comments - warning 50)"
| _ -> ""
in
Format.fprintf fmt "%s: ignoring %S%s\n%!" exe input_name reason ;
match exn with
| Syntaxerr.Error _ | Lexer.Error _ ->
Location.report_exception fmt exn
| Warning50 l ->
List.iter l ~f:(fun (l, w) -> Warning.print_warning l w) ;
Format.fprintf fmt
"@{<warning>Hint@}: (Warning 50) This file contains a \
documentation comment (** ... *) that the OCaml compiler \
does not know how to attach to the AST. OCamlformat does not \
support these cases. You can find more information at: \
https://github.com/ocaml-ppx/ocamlformat#overview. If you'd \
like to disable this check and let ocamlformat make a choice \
(though it might not be consistent with the ocaml compilers \
and odoc), you can set the --no-comment-check option.\n\
%!"
| exn -> Format.fprintf fmt "%s\n%!" (Exn.to_string exn) )
| Unstable {iteration; prev; next; input_name} ->
if debug then print_diff input_name ~prev ~next ;
if iteration <= 1 then
Format.fprintf fmt
"%s: %S was not already formatted. ([max-iters = 1])\n%!" exe
input_name
else (
Format.fprintf fmt
"%s: Cannot process %S.\n\
\ Please report this bug at \
https://github.com/ocaml-ppx/ocamlformat/issues.\n\
%!"
exe input_name ;
Format.fprintf fmt
" BUG: formatting did not stabilize after %i iterations.\n%!"
iteration )
| User_error msg -> Format.fprintf fmt "%s: %s.\n%!" exe msg
| Ocamlformat_bug {exn; input_name} -> (
Format.fprintf fmt
"%s: Cannot process %S.\n\
\ Please report this bug at \
https://github.com/ocaml-ppx/ocamlformat/issues.\n\
%!"
exe input_name ;
match exn with
| Internal_error (errors, l) ->
List.iter errors ~f:(print_internal_error ~debug ~quiet fmt) ;
if debug then
List.iter l ~f:(fun (msg, sexp) ->
Format.fprintf fmt " %s: %s\n%!" msg (Sexp.to_string sexp) )
| exn ->
Format.fprintf fmt
" BUG: unhandled exception. Use [--debug] for details.\n%!" ;
if debug then Format.fprintf fmt "%s\n%!" (Exn.to_string exn) )
end
let with_file input_name output_file suf ext f =
let dir =
match output_file with
| Some filename -> Filename.dirname filename
| None -> Filename.get_temp_dir_name ()
in
let base = Filename.remove_extension (Filename.basename input_name) in
let tmp = Filename.concat dir (base ^ suf ^ ext) in
Out_channel.with_file tmp ~f ;
tmp
let dump_ast ~input_name ?output_file ~suffix fmt =
let ext = ".ast" in
with_file input_name output_file suffix ext (fun oc ->
fmt (Format.formatter_of_out_channel oc) )
let dump_formatted ~input_name ?output_file
?(ext = Filename.extension input_name) ~suffix fmted =
with_file input_name output_file suffix ext (fun oc ->
Out_channel.output_string oc fmted )
let check_all_locations fmt cmts_t =
match Cmts.remaining_locs cmts_t with
| [] -> ()
| l ->
let print l = Format.fprintf fmt "%a\n%!" Location.print_loc l in
Format.fprintf fmt
"Warning: Some locations have not been considered\n%!" ;
List.iter ~f:print (List.sort l ~compare:Location.compare)
let check_margin (conf : Conf.t) ~filename ~fmted =
List.iteri (String.split_lines fmted) ~f:(fun i line ->
if String.length line > conf.fmt_opts.margin.v then
Format.fprintf Format.err_formatter
"Warning: %s:%i exceeds the margin\n%!" filename i )
let with_optional_box_debug ~box_debug k =
if box_debug then Fmt.with_box_debug k else k
let with_buffer_formatter ~buffer_size k =
let buffer = Buffer.create buffer_size in
let fs = Format_.formatter_of_buffer buffer in
Fmt.eval fs k ;
Format_.pp_print_flush fs () ;
if Buffer.length buffer > 0 then Format_.pp_print_newline fs () ;
Buffer.contents buffer
let strconst_mapper locs =
let constant self c =
match c.Parsetree.pconst_desc with
| Parsetree.Pconst_string (_, {Location.loc_start; loc_end; _}, Some _)
->
locs := (loc_start.Lexing.pos_cnum, loc_end.Lexing.pos_cnum) :: !locs ;
c
| _ -> Ast_mapper.default_mapper.constant self c
in
{Ast_mapper.default_mapper with constant}
let collect_strlocs (type a) (fg : a Extended_ast.t) (ast : a) :
(int * int) list =
let locs = ref [] in
let _ = Extended_ast.map fg (strconst_mapper locs) ast in
let compare (c1, _) (c2, _) = Stdlib.compare c1 c2 in
List.sort ~compare !locs
let check_remaining_comments cmts =
let dropped x = {Cmt.kind= `Dropped x; cmt_kind= `Comment} in
match Cmts.remaining_comments cmts with
| [] -> Ok ()
| cmts -> Error (List.map cmts ~f:dropped)
let (conf : Conf.t) cmts ~old:t_old ~new_:t_new =
let open Result in
if conf.opr_opts.comment_check.v then
let errors =
check_remaining_comments cmts
>>= fun () ->
let split_cmts = List.partition_map ~f:(Cmts.is_docstring conf) in
let old_docs, old_cmts = split_cmts t_old.comments in
let new_docs, new_cmts = split_cmts t_new.comments in
Normalize_extended_ast.diff_cmts conf old_cmts new_cmts
>>= fun () ->
Normalize_extended_ast.diff_docstrings conf old_docs new_docs
in
match errors with
| Ok () -> ()
| Error e -> internal_error (List.map e ~f:(fun x -> `Comment x)) []
let format (type a b) (fg : a Extended_ast.t) (std_fg : b Std_ast.t)
?output_file ~input_name ~prev_source ~parsed ~std_parsed (conf : Conf.t)
=
let dump_ast fg ~suffix ast =
if conf.opr_opts.debug.v then
Some
(dump_ast ~input_name ?output_file ~suffix (fun fmt ->
Std_ast.Printast.ast fg fmt ast ) )
else None
in
let dump_formatted ?ext ~suffix fmted =
if conf.opr_opts.debug.v then
Some (dump_formatted ?ext ~input_name ?output_file ~suffix fmted)
else None
in
Location.input_name := input_name ;
let rec print_check ~i ~(conf : Conf.t) ~prev_source t std_t =
let format ~box_debug =
let open Fmt in
let cmts_t =
Cmts.init fg ~debug:conf.opr_opts.debug.v t.source t.ast t.comments
in
let contents =
with_buffer_formatter
~buffer_size:(String.length prev_source)
( set_margin conf.fmt_opts.margin.v
$ set_max_indent conf.fmt_opts.max_indent.v
$ fmt_if_k
(not (String.is_empty t.prefix))
(str t.prefix $ fmt "@.")
$ with_optional_box_debug ~box_debug
(Fmt_ast.fmt_ast fg ~debug:conf.opr_opts.debug.v t.source
cmts_t conf t.ast ) )
in
(contents, cmts_t)
in
( if conf.opr_opts.debug.v then
format ~box_debug:true |> fst
|> dump_formatted ~suffix:"_boxes" ~ext:".html"
|> function
| Some file ->
if i = 1 then Format.eprintf "[DEBUG] Box structure: %s\n" file
| None -> () ) ;
let fmted, cmts_t = format ~box_debug:false in
let conf =
if conf.opr_opts.debug.v then conf
else
{ conf with
opr_opts=
{ conf.opr_opts with
quiet= {v= true; from= conf.opr_opts.quiet.from} } }
in
if String.equal prev_source fmted then (
if conf.opr_opts.debug.v then
check_all_locations Format.err_formatter cmts_t ;
if conf.opr_opts.margin_check.v then
check_margin conf ~fmted
~filename:(Option.value output_file ~default:input_name) ;
let strlocs = collect_strlocs fg t.ast in
Ok (strlocs, fmted) )
else
let exn_args () =
[("output file", dump_formatted ~suffix:".invalid-ast" fmted)]
|> List.filter_map ~f:(fun (s, f_opt) ->
Option.map f_opt ~f:(fun f -> (s, String.sexp_of_t f)) )
in
let+ t_new =
match
parse (parse_ast conf) ~disable_w50:true fg conf ~input_name
~source:fmted
with
| exception Sys_error msg -> Error (Error.User_error msg)
| exception exn -> internal_error [`Cannot_parse exn] (exn_args ())
| t_new -> Ok t_new
in
let+ std_t_new =
match
parse Std_ast.Parse.ast std_fg conf ~input_name ~source:fmted
with
| exception Sys_error msg -> Error (Error.User_error msg)
| exception Warning50 l ->
internal_error
(List.map ~f:(fun x -> `Warning50 x) l)
(exn_args ())
| exception exn -> internal_error [`Cannot_parse exn] (exn_args ())
| std_t_new -> Ok std_t_new
in
( if
(not
(Normalize_std_ast.equal std_fg conf std_t.ast std_t_new.ast
~ignore_doc_comments:(not conf.opr_opts.comment_check.v) ) )
&& not
(Normalize_extended_ast.equal fg conf t.ast t_new.ast
~ignore_doc_comments:(not conf.opr_opts.comment_check.v) )
then
let old_ast =
dump_ast std_fg ~suffix:".old"
(Normalize_std_ast.ast std_fg conf std_t.ast)
in
let new_ast =
dump_ast std_fg ~suffix:".new"
(Normalize_std_ast.ast std_fg conf std_t_new.ast)
in
let args ~suffix =
[ ("output file", dump_formatted ~suffix fmted)
; ("old ast", old_ast)
; ("new ast", new_ast) ]
|> List.filter_map ~f:(fun (s, f_opt) ->
Option.map f_opt ~f:(fun f -> (s, String.sexp_of_t f)) )
in
if
Normalize_std_ast.equal std_fg ~ignore_doc_comments:true conf
std_t.ast std_t_new.ast
then
let docstrings =
Normalize_std_ast.moved_docstrings std_fg conf std_t.ast
std_t_new.ast
in
let args = args ~suffix:".unequal-docs" in
internal_error
(List.map ~f:(fun x -> `Comment x) docstrings)
args
else
let args = args ~suffix:".unequal-ast" in
internal_error [`Ast_changed] args
else
dump_ast std_fg ~suffix:""
(Normalize_std_ast.ast std_fg conf std_t_new.ast)
|> function
| Some file ->
if i = 1 then Format.eprintf "[DEBUG] AST structure: %s\n" file
| None -> () ) ;
check_comments conf cmts_t ~old:t ~new_:t_new ;
if i >= conf.opr_opts.max_iters.v then (
Stdlib.flush_all () ;
Error
(Unstable {iteration= i; prev= prev_source; next= fmted; input_name}
) )
else
print_check ~i:(i + 1) ~conf ~prev_source:fmted t_new std_t_new
in
try print_check ~i:1 ~conf ~prev_source parsed std_parsed with
| Sys_error msg -> Error (User_error msg)
| exn -> Error (Ocamlformat_bug {exn; input_name})
let parse_result ?disable_w50 f fragment conf ~source ~input_name =
match parse ?disable_w50 f fragment conf ~input_name ~source with
| exception exn -> Error (Error.Invalid_source {exn; input_name})
| parsed -> Ok parsed
let parse_and_format (type a b) (fg : a Extended_ast.t)
(std_fg : b Std_ast.t) ?output_file ~input_name ~source (conf : Conf.t) =
Location.input_name := input_name ;
let line_endings = conf.fmt_opts.line_endings.v in
let+ parsed =
parse_result (parse_ast conf) ~disable_w50:true fg conf ~source
~input_name
in
let+ std_parsed =
parse_result Std_ast.Parse.ast std_fg conf ~source ~input_name
in
let+ strlocs, formatted =
format fg std_fg ?output_file ~input_name ~prev_source:source ~parsed
~std_parsed conf
in
Ok (Eol_compat.normalize_eol ~exclude_locs:strlocs ~line_endings formatted)
let parse_and_format syntax =
let (Extended_ast.Any ext) = Extended_ast.of_syntax syntax in
let (Std_ast.Any std) = Std_ast.of_syntax syntax in
parse_and_format ext std